WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [patch 04/26] Xen-paravirt_ops: Add pagetable accessors

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [patch 04/26] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries
From: Ingo Molnar <mingo@xxxxxxx>
Date: Wed, 28 Feb 2007 09:32:03 +0100
Cc: Zachary Amsden <zach@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Chris Wright <chrisw@xxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 28 Feb 2007 00:38:46 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45E47DEF.70405@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070227081337.434798469@xxxxxxxx> <20070227081630.311681690@xxxxxxxx> <20070227100850.GA10827@xxxxxxx> <45E47DEF.70405@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.2i
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> >> +#ifdef CONFIG_PARAVIRT
> >> +/* After pte_t, etc, have been defined */
> >> +#include <asm/paravirt.h>
> >> +#endif
> >>     
> >
> > hm - there's already a CONFIG_PARAVIRT conditional in 
> > asm-i386/paravirt.h.
> 
> Yes, but it happens after asm/paravirt.h has already included some 
> things, and it ends up causing problems.  paravirt.h still defines 
> various stub functions in the !CONFIG_PARAVIRT case, so it needs to do 
> the includes either way.

hm, it then needs to be fixed first, instead of adding to the mess.

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>