xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] [XEN][ACM] fix missing spin_unlock

from [Stefan Berger]

[Permanent Link][Original]

To:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] [XEN][ACM] fix missing spin_unlock
From:	Stefan Berger <stefanb@xxxxxxxxxx>
Date:	Mon, 26 Feb 2007 14:57:08 -0500
Cc:	sailer@xxxxxxxxxx
Delivery-date:	Mon, 26 Feb 2007 11:53:18 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Insert a missing spin_unlock statement.

Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>

Keir,

  I have a question regarding the event channel data structure. It looks
like a stale entry is in the event channel array indicating that a event
channel at a given port has a certain remote domain as target. However,
that domain does not exist anymore and therefore the code section where
I add the spin_unlock() call gets triggered now. Could this be a bug in
the domain-cleanup code?

  I can trigger this problem when running the xm-test suite with ACM
compiled into Xen. After 159 domains have been created, which happens to
be during the list tests, the stale port entry shows up and remains. The
list tests when run after a reboot do not trigger this, though.

  Stefan

acm_missing_spin_unlock.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] [XEN][ACM] fix missing spin_unlock, Stefan Berger <= [Xen-devel] Re: [PATCH] [XEN][ACM] fix missing spin_unlock, Keir Fraser

Previous by Date:	Re: [Xen-devel] Re: [PATCH] Require that xenstored writes to a domain complete in a single chunk, John Levon
Next by Date:	[Xen-devel] [PATCH] retry 3: use i386 swiotlb code in lib/swiotlb-xen.c [1/2], Langsdorf, Mark
Previous by Thread:	[Xen-devel] [PATCH][HVM][SVM] Save/Restore: Remove commented out code., Petersson, Mats
Next by Thread:	[Xen-devel] Re: [PATCH] [XEN][ACM] fix missing spin_unlock, Keir Fraser
Indexes:	[Date] [Thread] [Top] [All Lists]