WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump o

To: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump on Dom0
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 23 Feb 2007 18:43:36 +0000
Delivery-date: Fri, 23 Feb 2007 10:43:00 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <342BAC0A5467384983B586A6B0B3767104BE0B0E@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdO73yfygbdSnxbR/2AnMRpBcbdNgAy2MewAXo9PloACVlAIAAAS21yAGSDywAAAszgRQAD8etAAABE8FAAAIBJFw==
Thread-topic: [Xen-devel] [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump on Dom0
User-agent: Microsoft-Entourage/11.2.5.060620
On 23/2/07 18:32, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:

>> 2. You need it in xcutil because this directory has code that includes
>>    xc_private.h -- this seems wrong/bad to me but I wasn't prepared
>>    to change it!
>> 
> 
> Actually, it's xcutils/readnotes.c that #include's xg_private.h (which
> in turn includes xc_private.h) -- since the function that does the
> advise call is inline in xc_private.h, this wont compile unless
> _GNU_SOURCE is defined...

Put the Linux definition in xc_linux.c. Put a default dummy implementation
in xc_private.c with __attribute__ ((weak)). If you have only a function
prototype in xc_private.h then you won't need -D_GNU_SOURCE for
xcutil/Makefile.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel