|
|
|
|
|
|
|
|
|
|
xen-devel
[Xen-devel] Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache
To: |
"Jeremy Fitzhardinge" <jeremy@xxxxxxxx> |
Subject: |
[Xen-devel] Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache |
From: |
"Pekka Enberg" <penberg@xxxxxxxxxxxxxx> |
Date: |
Fri, 16 Feb 2007 10:39:33 +0200 |
Cc: |
Zachary Amsden <zach@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Chris Wright <chrisw@xxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
Delivery-date: |
Fri, 16 Feb 2007 05:39:47 -0800 |
Domainkey-signature: |
a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=Vdb5WVB82ngvqQhIr435RGqKYLMlQBMSgO2G3DpjfletMoSFiw9L0lo1wpayTyue0+PKzxZujwpvkzghq8LuCGPYhaQk5dW/yF3IZmHk1Aog8tlUr11BgIXGxIcXnIkhhXEMZnWsA8QW1XM3EYkXoWgg2npCAk8SKy824ool8iM= |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
In-reply-to: |
<20070216022531.047039320@xxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<20070216022449.739760547@xxxxxxxx> <20070216022531.047039320@xxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 2/16/07, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
Remove the ctor for the pgd cache. There's no point in having the
cache machinery do this via an indirect call when all pgd are freed in
the one place anyway.
The reason we have slab constructors and destructors is to _avoid_
reinitializing every time we allocate an object. AFAICT your changing
the code now to do _more_ work than before, so is there some other
reason why you want to do this than avoiding an indirect call?
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|