xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] x86: fix NMI delivery to dom0

from [Jan Beulich]

[Permanent Link][Original]

To:	<xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] x86: fix NMI delivery to dom0
From:	"Jan Beulich" <jbeulich@xxxxxxxxxx>
Date:	Mon, 12 Feb 2007 13:06:03 +0000
Delivery-date:	Mon, 12 Feb 2007 05:11:41 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

As I understand it, the condition for raising the respective softirq was 
inverted.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: 2007-02-07/xen/arch/x86/traps.c
===================================================================
--- 2007-02-07.orig/xen/arch/x86/traps.c        2007-02-07 16:32:43.000000000 
+0100
+++ 2007-02-07/xen/arch/x86/traps.c     2007-02-12 13:53:44.000000000 +0100
@@ -1804,7 +1804,7 @@ static void nmi_dom0_report(unsigned int
 
     set_bit(reason_idx, nmi_reason(d));
 
-    if ( test_and_set_bit(_VCPUF_nmi_pending, &v->vcpu_flags) )
+    if ( !test_and_set_bit(_VCPUF_nmi_pending, &v->vcpu_flags) )
         raise_softirq(NMI_SOFTIRQ); /* not safe to wake up a vcpu here */
 }
 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86: fix NMI delivery to dom0, Jan Beulich <=

Previous by Date:	[Xen-devel] RE: [Xen-users] Does VT-d make live migration of Xen more difficult by reducing the size of abstraction layer?, Petersson, Mats
Next by Date:	[Xen-devel] [PATCH] lift physical address restriction in svae/restore code, Jan Beulich
Previous by Thread:	[Xen-devel] PNPACPI dependency removal on TCG_TIS, Jan Beulich
Next by Thread:	[Xen-devel] [PATCH] lift physical address restriction in svae/restore code, Jan Beulich
Indexes:	[Date] [Thread] [Top] [All Lists]