WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Add -Wcast-qual flag

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Add -Wcast-qual flag
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Thu, 21 Dec 2006 15:56:11 +0100
Cc: Keir Fraser <keir@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date: Thu, 21 Dec 2006 06:56:18 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <458AA5C8.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: AMD / OSRC
References: <458A915B.76E4.0078.0@xxxxxxxxxx> <C1B03C6A.6B25%keir@xxxxxxxxxxxxx> <458AA5C8.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.4
On Thursday 21 December 2006 15:18, Jan Beulich wrote:
> >>> Keir Fraser <keir@xxxxxxxxxxxxx> 21.12.06 14:28 >>>
> >
> >On 21/12/06 12:51, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
> >> While I'd really like to see all Xen code become const-correct (because
> >> I do believe this helps with code quality, like does marking read only
> >> data read only in the page tables), I don't think adding the warning
> >> here is appropriate - after all, in C this is one of the purposes of
> >> adding explicit casts (although I agree it's questionable to use casts
> >> for this purpose). And no, I don't think that many people screwing up
> >> const placement is a proper argument for not using const where possible.
> >
> >Well, I'm inclined to take the clean-up parts of the patches but leave out
> >__UNCONST() and -Wcast-qual. I really dislike the compiler thinking it
> > knows better than an explicit cast, and casting via unsigned long is just
> > a kludge.
>
> This I completely agree with.

Me, too. I mentioned in my first mail, these parts with __UNCONST() must be 
reworked to get rid of it. There was no obvious solution for me at least.
If someone knows a way, I am for it.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel