[Xen-devel] Re: [PATCH resend] allow connecting to xenconsole from remote hosts

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 27/9/06 22:14, "Muli Ben-Yehuda" <muli@xxxxxxxxxx> wrote:

>>  2. I think the buffering code is not quite there yet. What you want is to
>> make all fd's non-blocking, have small (e.g., 1kB) buffers, and then only
>> add an fd to the read-set if its buffer is not full,  and only add an fd to
>> the write-set if its buffer is not empty. The buffers can stay as ring
>> buffers, so a bunch of that code probably stays.
> 
> Ok. I think it will end up being more code than what we do right now,
> but if you prefer it this way, fine.

We'll see. I think it'll be more readable to have the two issues addresses
in separate patches anyway.

>>  3. The networking options are confusing. What are the 'remote' and
>> 'gateway' options intended for?
> 
> --remote = activate the networking.
> --gateway = allow connections from any host, not just localhost

Isn't --remote implied by --port? Is it useful to be able to select
networking yet not specify a port? I think --remote is a better name for
--gateway (i.e., you accept remote connections). The term 'gateway' doesn't
mean anything to me in this context.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel