xen-devel

[Top] [All Lists]

[Xen-devel] [Patch] blktap modular build fix

from [Stephen C. Tweedie]

[Permanent Link][Original]

To:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [Patch] blktap modular build fix
From:	"Stephen C. Tweedie" <sct@xxxxxxxxxx>
Date:	Wed, 27 Sep 2006 14:45:15 +0100
Delivery-date:	Wed, 27 Sep 2006 06:45:52 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

[[[WARNING TO COMMITTER: this patch also requires blktap.c to be renamed
to blktapmain.c in order to avoid the .c/module naming conflict.]]]

The kernel blktap.c cannot build as a module: its makefile is broken for
modular build, and it is also impossible to build a module from
multiple .o files where the module name coincides with one of the source
files.

Signed-off-by: Stephen Tweedie <sct@xxxxxxxxxx>

diff --exclude-from=/dev/fd/63 -ur 
linux-2.6.18.noarch/drivers/xen/blktap/Makefile 
kernel-2.6.18.blktap/linux-2.6.18.noarch/drivers/xen/blktap/Makefile
--- linux-2.6.18.noarch/drivers/xen/blktap/Makefile     2006-09-25 
21:32:06.000000000 +0100
+++ kernel-2.6.18.blktap/linux-2.6.18.noarch/drivers/xen/blktap/Makefile        
2006-09-21 20:25:09.000000000 +0100
@@ -1,3 +1,6 @@
 LINUXINCLUDE += -I../xen/include/public/io
-obj-y  := xenbus.o interface.o blktap.o 
+
+obj-$(CONFIG_XEN_BLKDEV_TAP) := blktap.o
+
+blktap-y       := xenbus.o interface.o blktapmain.o 
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [Patch] blktap modular build fix, Stephen C. Tweedie <=

Previous by Date:	[Xen-devel] Broken (and unnecessary) SMP locking in blktap.c, Stephen C. Tweedie
Next by Date:	Re: [Xen-devel] Testing status of HVM (Intel VT) on 64bit XENunstable c/s 11616, Keir Fraser
Previous by Thread:	[Xen-devel] Broken (and unnecessary) SMP locking in blktap.c, Stephen C. Tweedie
Next by Thread:	[Xen-devel] [PATCH] typo in create.py, Charles Coffing
Indexes:	[Date] [Thread] [Top] [All Lists]