xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value

from [KUWAMURA Shin'ya]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	Re: [Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value
From:	"KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>
Date:	Tue, 19 Sep 2006 13:57:55 +0900 (JST)
Delivery-date:	Mon, 18 Sep 2006 22:01:37 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20060908.105047.77000778.kuwa@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20060908.105047.77000778.kuwa@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi,

Do you have any comment?
If you have no comment, could you commit this patch?

http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00244.html

On <20060908.105047.77000778.kuwa@xxxxxxxxxxxxxx>,
 "KUWAMURA Shin'ya" said:
> 
> This patch adds the argument check of "--ms_per_sample" option. 
> 
> If a value of "--ms_per_sample" option is larger than a value of
> "--time" option, xenmon may generate no log file. So, too large
> "--ms_per_sample" should be treated as an error.
> 
> e.g. 
>   % xenmon.py --ms_per_sample=2000 -t 1 -n
>   usage: xenmon.py [options]
>   
>   xenmon.py: error: option --ms_per_sample: too large (> 1000 ms)
> 
> # Notice that a unit of "--time" is a second.
> 
> Signed-off-by: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>

Best Regards,
-- 
  KUWAMURA Shin'ya

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value, KUWAMURA Shin'ya Re: [Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value, KUWAMURA Shin'ya <=

Previous by Date:	[Xen-devel] How to enable audio in vmx guest, Huang, Xinmei
Next by Date:	[Xen-devel] [RESEND] [PATCH] Use GDB 'O' packets for console output, Tony Breeds
Previous by Thread:	[Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value, KUWAMURA Shin'ya
Next by Thread:	[Xen-devel] [PATCH] Add the upper/lower limit checking for xm sched-credit, Masaki Kanno
Indexes:	[Date] [Thread] [Top] [All Lists]