Re: [Xen-devel] [PATCH][RESEND] Add syntax checking for xmblock-

>On Fri, 2006-09-08 at 10:31 +0900, Masaki Kanno wrote:
>> +        # 'r'  : read-only mode
>> +        # 'w'  : read-write mode
>> +        # 'w!' : read-write and it is safe to have multiple writers on 
>> this device
>> +        mode = sxp.child_value(config, 'mode', 'r')
>> +        if mode != 'r' and mode != 'w' and mode != 'w!':
>> +            raise VmError('Invalid mode')
>
>I don't think the comments are necessary; those are pretty standard.
>
>Also, try this for your test:
>       if mode not in ('r', 'w', 'w!'):
>               raise VmError('Invalid mode')

Hi Hollis,

Thanks for your comments and example codes. 

Best regards,
 Kan

>
>-- 
>Hollis Blanchard
>IBM Linux Technology Center
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH][RESEND] Add syntax checking for xm block-attach, Masaki Kanno Re: [Xen-devel] [PATCH][RESEND] Add syntax checking for xm block-attach, Hollis Blanchard Re: [Xen-devel] [PATCH][RESEND] Add syntax checking for xmblock-attach, Masaki Kanno <=

Previous by Date:

[Xen-devel] please pull xen-ia64-unstable.hg, Alex Williamson

Next by Date:

[Xen-devel] [PATCH][RESEND*2] Add syntax checking for xm block-attach, Masaki Kanno

Previous by Thread:

Re: [Xen-devel] [PATCH][RESEND] Add syntax checking for xm block-attach, Hollis Blanchard

Next by Thread:

[Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value, KUWAMURA Shin'ya

Indexes:

[Date] [Thread] [Top] [All Lists]