xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] Add syntax checking for xm block-attach

from [Masaki Kanno]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] Add syntax checking for xm block-attach
From:	Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date:	Wed, 06 Sep 2006 20:49:05 +0900
Delivery-date:	Wed, 06 Sep 2006 04:50:17 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi,

Currently, xm block-attach command doesn't have syntax checking 
about the mode('r' or 'w').  Even if wrong characters to the 
mode are specified, VBD is attached to VM with the read-only 
mode.

# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769  
# xm block-attach vm1 phy:ram2 hdb1 xyz
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769  
833    0    0     4      8      585   /local/domain/0/backend/vbd/2/833  


This patch adds syntax checking for xm block-attach command.

# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769  
# xm block-attach vm1 phy:ram2 hdb1 xyz
Error: Invalid mode
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769  


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

block-attach.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Add syntax checking for xm block-attach, Masaki Kanno <= Re: [Xen-devel] [PATCH] Add syntax checking for xm block-attach, Ewan Mellor Re: [Xen-devel] [PATCH] Add syntax checking for xm block-attach, Masaki Kanno

Previous by Date:	Re: [Xen-devel] [PATCH] Paravirt framebuffer support in xend [3/5], sos22-xen
Next by Date:	[XenPPC] should vcpu_pause()/vcpu_sleep_nosync() give up?, Jimi Xenidis
Previous by Thread:	[Xen-devel] [RFC PATCH] allow connecting to xenconsole from remote hosts, Muli Ben-Yehuda
Next by Thread:	Re: [Xen-devel] [PATCH] Add syntax checking for xm block-attach, Ewan Mellor
Indexes:	[Date] [Thread] [Top] [All Lists]