Re: [Xen-devel] [PATCH] XEN: use C locale in bootup message

[Horms <horms@xxxxxxxxxxxx>]

On Thu, Aug 31, 2006 at 10:49:59PM +0100, Keir Fraser wrote:
> 
> 
> 
> On 31/8/06 5:27 am, "Horms" <horms@xxxxxxxxxxxx> wrote:
> 
> > And in that environment Japanese text was ending up in
> > include/xen/compile.h, and coming out as complete garbage
> > on xen console over serial.
> 
> Was it just date values coming out in Japanese? If so, can we get away with
> just setting LC_TIME=C (not setting LANG or LC_ALL at all)?

Yes, only date seems to be the problem. The fix could be limited to
inside of $(shell date), I think $(shell LC_ALL=C date) would solve
the problem that I am seeing. However setting LC_TIME does not resolve
the problem, as if LC_ALL is set in the environment it seems that
LC_TIME is ignored.

As for LANG, I think that is irrelevant for date. 
I suspect we can get rid of it all together without any ill effects.

The reason that I went with a more general (sledge-hammer) approach as
I'm not sure what other commands may be affected with other locales.
But it is probably safe enough just to set LC_ALL for date. If you would
like me to come up with a more minimal patch that fixes the problem for
Japanese environments at least, and probably all environments, let me
know. Its probably a bit easier for me to test than you.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel