WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/3] Output Virtual Block Device requests informa

To: "Satoshi Uchida" <s-uchida@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/3] Output Virtual Block Device requests information to /proc/xen/vbd
From: NAHieu <nahieu@xxxxxxxxx>
Date: Thu, 22 Jun 2006 01:13:21 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 21 Jun 2006 09:13:46 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=r9OZMH1R5EHdS4W/CUPNCDtarYr7tnRpAsuBviLbc2TmT9fJ4xcbcMxjUPoXzPjGlSiBc3Wp1Ma0eIGxqQdE3DAJM8Jjx21FlXXFAHejXBH5Y4/u5b4+qFs5KOhXLwuqvS4VvTD6aGP53U2N1z8OpKI+tLwlOYd4zspMJJ/m2Pc=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <008201c69518$40ff8880$4c87380a@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <008201c69518$40ff8880$4c87380a@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

I looked at the code, and it seems "oo" stands of "out of", which
indicates how much we were out of request (Xen supports up to 64
requests in queue)

Few minor comments:
- The variable dom_io_info_wq is unused, should be removed.
- printk("%s: out of memory\n", __FUNCTION__) should be used with KERN_ERR

I have one question: in your below output:

Domain 4 - oo        0  rd    18699  wr        2
 xvd 4  8:21 - oo        0  rd    18699  wr        2

I notice that you output the domid with xvd (4), but in the above
line, we already had that information (Domain 4). So why you need to
show the domid again?

Thanks,
H

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel