Re: [Xen-devel] [PATCH] Add dm-userspace to the Xen kernel

[Bastian Blank <bastian@xxxxxxxxxxxx>]

On Fri, Jun 09, 2006 at 02:08:15PM -0700, Dan Smith wrote:
> ++/*
> ++ * This is the message that is passed back and forth between the
> ++ * kernel and the user application
> ++ */
> ++struct dmu_write {
> ++    uint32_t id;
> ++    uint32_t type;              /* Type of request */
> ++    uint32_t flags;        /* Flags */
> ++
> ++    uint64_t org_block;    /* Block that was accessed */
> ++    uint64_t new_block;    /* The new block it should go to */
> ++    int64_t offset;        /* Sector offset of the block, if needed  */
> ++
> ++    uint32_t src_maj;      /* The source device for copying */
> ++    uint32_t src_min;
> ++
> ++    uint32_t dest_maj;     /* Destination device for copying, and */
> ++    uint32_t dest_min;     /* for the block access                */
> ++
> ++};
> ++
> ++#endif

Any reason why
1. this struct differs from the old patches published on dm-devel and
   lkml?
2. Why do you use a construct which gives different allignment on i386
   and x86_64? (i386 alligns 64bit ints on 32bit, x86_64 on 64bit

Bastian

-- 
A woman should have compassion.
                -- Kirk, "Catspaw", stardate 3018.2

signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel