Re: [Xen-devel] [PATCH] change dom0 headers path

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Thu, Apr 20, 2006 at 03:40:37PM +0100, John Levon wrote:

> So, something more like:
> 
> libxc/xc_linux.c
> libxc/xc_solaris.c
> libxc/xen/linux/
> libxc/xen/solaris/

Hmm. Looking at this, we've got an awful lot of duplicated code between
xc_{linux,solaris}.c if we only let those files see the kernel headers
containing privcmd_hypercall_t etc.

Wouldn't it be better to have a libxc/xen/sys/[1] symlink so that
xc_private.c and friends can continue to include privcmd_hypercall etc?
That way the contents of xc_{linux,solaris}.c can contain only the parts
that we'll genuinely differ by (use of /proc etc.).

regards
john

[1] or some other name since 'dom0' won't do

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel