This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] changeset 8831 gets sockets, cores, and siblings

To: Andrew Theurer <habanero@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] changeset 8831 gets sockets, cores, and siblings wrong
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 16 Feb 2006 18:27:28 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 16 Feb 2006 18:33:37 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43F4C1FC.9000405@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <43F39B4B.6080806@xxxxxxxxxx> <d78f897640ab3448e8e8a283497e9ff1@xxxxxxxxxxxx> <43F4C1FC.9000405@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 16 Feb 2006, at 18:18, Andrew Theurer wrote:

It looks like with changeset 8831 cpu_core_ids are no longer unique across phys cpus. So, when we search for siblings to populate cpu_sibling_map, just checking for same core IDs are not good enough. Both core ID and phys cpu ID have to match. Patch attached fixes this.

Thanks. It turns out all that code in smpboot.c disappeared in the latest 2.6 codebase, so I upgraded to that and the problem has gone away. :-)

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>