Re: [Xen-devel] USB virt 2.6 split driver patch series

[NAHieu <nahieu@xxxxxxxxx>]

On 11/21/05, harry <harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 2005-11-21 at 14:49 +0100, Vincent Hanquez wrote:
> > On Mon, Nov 21, 2005 at 01:18:24PM +0000, harry wrote:
> > > o - I've reformatted all the code to the kernel coding style using
> > > Lindent and not attempted to improve it after that.  Some of the
> > > formatting needs to be improved.
> >
> > some ? this is totally _not_ linux kernel coding style.
> > please have a look at Documentation/CodingStyle and kill anonymous
> > inline functions (braces in middle of functions).
> >
>
> I have read  Documentation/CodingStyle quite carefully and there is no
> mention of using braces inside functions.  I'm used to using braces to
> define minimal scopes for local variables which makes the code easier to
> read by minimising the number of variables you need to keep track of
> when reading it and by declaring variables closer to where they are used
> so it is easier to verify that they have been correctly initialised.
>
> Is this really banned?
>

I guess people complain because this is not a common practice. At
least I never seen any code like that in the kernel.

You could remove them because your functions are pretty short, and it
easy enough to follow the code even if you put all the variables at
the top of functions.


Hieu

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel