WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Recent trace patch not arch-neutral

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] Recent trace patch not arch-neutral
From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Date: Mon, 31 Oct 2005 14:32:05 -0800
Delivery-date: Mon, 31 Oct 2005 22:29:11 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcXeYrvzn+u/0749QG6KWctXqcALtgABg3TAAABKMXA=
Thread-topic: [Xen-devel] Recent trace patch not arch-neutral
> > A recent patch to trace.c uses a call to rdtscll() which is 
> > x86-specific.  Is there an arch-neutral call that can be used 
> > instead?  Or do arch's need to implement this?  (And if the 
> > latter, should we choose a more generic name?)
> 
> The tracebuffer code has always used the cycle counter, so if you've
> previously been compiling it for ia64 it must have previously 
> been using
> some more arch neutral way of accessing it...

OK, from the hg annotated manifest it appeared (on first
glance) to be recently added.

Still not positive, but I think Xen/ia64 was compiling but
never linking in trace.c because the call from dom0_ops.c
to tb_control was controlled by #ifdef TRACE_BUFFER,
that ifdef is now gone, and Xen/ia64 never turned it on.

Looking quickly over trace.c, all appears to be arch-neutral
except for the call to rdtscll(), so the questions remain...

Is there an arch-neutral call that can be used 
instead?  Or do arch's need to implement this?  (And if the 
latter, should we choose a more generic name?)

Dan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>