WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] remove extra field from vcpuinfo python binding

To: Ryan Harper <ryanh@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] remove extra field from vcpuinfo python binding
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 18 Oct 2005 11:00:13 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 18 Oct 2005 09:52:29 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20051017230825.GC17358@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20051017230825.GC17358@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 18 Oct 2005, at 00:08, Ryan Harper wrote:

There are only six fields in vcpuinfo, also cpumap_t is a u64, so use
[1]"K" for parsing cpumap.

1. http://www.python.org/doc/2.4.1/api/arg-parsing.html

I won't change to 'K' because that is not supported by Python 2.2, and also because it leaves the cpumap argument to domain_pincpu() as an 'i'.

Furthermore, I disagree with exporting cpu bitmaps into Python. I think it would be much nicer to pass lists of cpus (i.e., lists of ints) to and fro at that interface, and have xc.c do the conversion between lists and bitmaps. I would gladly take a patch that implements this.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>