WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] 32/64-bit hypercall interface

To: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Subject: Re: [Xen-devel] 32/64-bit hypercall interface
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Tue, 4 Oct 2005 17:47:23 -0500
Cc: Jeremy Katz <katzj@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>
Delivery-date: Tue, 04 Oct 2005 22:45:56 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7F740D512C7C1046AB53446D3720017305704345@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <7F740D512C7C1046AB53446D3720017305704345@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.8.2
On Tuesday 04 October 2005 16:51, Nakajima, Jun wrote:
> Okay, I understand what you need. How about the data layout? That's not
> so trivial to have the identical ones.
> For example, the following one would have different data layout on
> 32-bit and 64-bit.
>
> typedef struct vcpu_time_info {
>     u32 version;
>     u64 tsc_timestamp;   /* TSC at last update of time vals.  */
>     u64 system_time;     /* Time, in nanosecs, since boot.    */
>     u32 tsc_to_system_mul;
>     s8  tsc_shift;
> } vcpu_time_info_t;

Is that because of the u64 4-byte alignment Andi mentioned? To use u64 in 
xen/include/public, we will need to ensure that __aligned__((8)) is used.

The padding in some of these structures is unfortunate in terms of wasted 
(cacheline) space, but for now I will be happy with commonizing the size and 
layout. This particular structure couldn't be compacted anyways... However, 
Keir indicated earlier he was not interested in reordering any structures, as 
would be needed to reduce wasted padding space.

-- 
Hollis Blanchard
IBM Linux Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel