WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][VT] Patch to allow VMX domains to be destroyed o

To: Khoa Huynh <khoa@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][VT] Patch to allow VMX domains to be destroyed or shut down cleanly
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 13 Sep 2005 20:10:04 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 13 Sep 2005 19:15:08 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <OF1692E3F2.C5F74158-ON8525707B.005516D0-8625707B.0058DEA7@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OF1692E3F2.C5F74158-ON8525707B.005516D0-8625707B.0058DEA7@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 13 Sep 2005, at 17:10, Khoa Huynh wrote:

I have tested this to some extent with both VMX (Windows XP) and non-VMX
domains.  So far so good.

It's good to understand the problem some more, and I think I like your general approach. However, although your current patch drops the domain refcnts, it leaves the tainted-refcnt pages allocated. Worse, they are left allocated and with a dangling domain pointer. Probably we should hit those page refcnts on the head (i.e., to zero). One fly in the ointment is if some refcnts are non-zero because other domains have mappings of them (e.g., device model in domain0)...

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel