This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0

To: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Sun, 26 Jun 2005 12:10:24 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 26 Jun 2005 16:09:27 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200506260249.18338.mark.williamson@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 06/25/2005 09:49:18 PM:

> On Sunday 26 June 2005 02:45, aq wrote:
> > looks like this patch (and also many other codes in the tree) mixed of
> > tabs and spaces for indentation :-(. especially this code will be in
> > mainline in the future.
> >
> > is it time for us to have a official *coding style guide*, and all the
> > patches sent in must comply with the guide in order to be picked up
> > ???
> It seems sensible for XenLinux code to follow the Linux CodingStyle 
> (although I'm not sure all the drivers do this yet).
> Xen-related C code that isn't destined for the Linux kernel itself has a 

> different coding style:
> * we indent in blocks of 4 spaces and don't use tabs

The drivers in the Linux sparse directory, are they falling under this 

> * { and } are always on a new line, unlike K&R style
> * we put a space between an if and the open parenthesis, and between the 

> parentheses and the boolean: if ( murble )

If there was a script that we could run over the code, it would make life 


Xen-devel mailing list