This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Makefile version.

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Makefile version.
From: aq <aquynh@xxxxxxxxx>
Date: Sat, 25 Jun 2005 20:08:45 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 26 Jun 2005 01:07:43 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=LThSmVFH4sqHXNrHrMW3NUZF6XxPotrVlV6GpGjOAPn20zUT62uu0Tgg/jnVGnSVxCsF4xeSbxkKim5w0n/hlTo7JO30J56jVZPIz8wUW663J7nKc7tUOGEwen2UI63/IkyT8BLrc5h+Pqh4CxYqj2W9z9d0cPm5VT3Cxlz2HOk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <17085.40317.97560.935556@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <17085.34823.894079.739424@xxxxxxxxxxxxxxxxxxxxx> <9d88d759c77007e379866a4bdc609915@xxxxxxxxxxxx> <17085.40317.97560.935556@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: aq <aquynh@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 6/25/05, Jimi Xenidis <jimix@xxxxxxxxxxxxxx> wrote:
> >>>>> "KF" == Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> writes:
>  KF> On 25 Jun 2005, at 17:36, Jimi Xenidis wrote:
>  >> Example:
>  >> foo.o: CFLAGS += -DFOO_DEBUG
>  KF> Yeah, we allow those. I think they were added before 3.8x, otherwise we
>  KF> wouldn't use them (we started using $(eval), which is a 3.8x feature,
>  KF> and had complaints from 3.79 users).
> Ok cool, that means I can remove my custom %.o:%.c commands and just
> define CFLAGS for the target.
> would also like to add an $(AFLAGS) to the %.o: %.S rule liek the
> following diffs.
> This allows me to further customize some assemble, paritularly to add
> -Wa,-gdwarf2, as the followign diff shows:
> --- /tmp/geta14981      2005-06-25 14:05:11.000000000 -0400
> +++ Rules.mk    2005-06-25 12:21:57.000000000 -0400
> @@ -80,5 +80,5 @@
>         $(CC) $(CFLAGS) -c $< -o $@
>  %.o: %.S $(HDRS) Makefile
> -       $(CC) $(CFLAGS) -D__ASSEMBLY__ -c $< -o $@
> +       $(CC) $(CFLAGS) $(AFLAGS) -D__ASSEMBLY__ -c $< -o $@

you should always use diff from outside of xen root directory (so
patch would be used with -p1 option). otherwise, it is impossible to
know where to apply this patch (there are many Rules.mk file in the
source tree)


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>