This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] Fixing iopl and ioperm

To: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Fixing iopl and ioperm
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Tue, 14 Jun 2005 08:22:21 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 14 Jun 2005 00:21:36 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcVwaXK8N6xvUM3OQdePRmdyyiW1ZgAAVa6wAAFfx0A=
Thread-topic: [Xen-devel] [PATCH] Fixing iopl and ioperm
On xeno32, test case iopl02 of LTP will fail, pls see below:

[root@vt-x bin]# uname -a
Linux vt-x #1 Mon Jun 13 16:58:09 PDT 2005 i686 i686 i386
[root@vt-x bin]# ./iopl02
iopl02      1  PASS  :  Expected failure for Invalid privilege level,
errno: 22
iopl02      2  FAIL  :  Unexpected results for Non super-user ; returned
0 (expected -1), errno 0 (expected errno  1)

With the ioport patch, this bug get fixed.


Nakajima, Jun wrote:
> Keir Fraser wrote:
>> On 11 Jun 2005, at 06:45, Nakajima, Jun wrote:
>>> With this patch, x86 and x86-64 share ioport.c, fixing
>>> LTP iopl and ioperm testcase failures (on both). We
>>> found an iopl testcase failing even on x86 xenlinux. 
>>> Now x86-64 xenlinux should have the same results
>>> regarding the LTP testcases (as far as we tested).
>> Why does this patch modify the i386 ioport.c so much? I
>> would expect that you ought to be able to use the
>> xen/i386 ioport.c with no modification at all. The
>> different function prototypes for sys_iopl between i386
>> and x86_64 shouldn't matter -- x86_64 ought to work with
>> teh existing xen/i386 function prototype and function
>> implementation.  
> That part is basically coming from the implementation of
> set_bitmap; x86 and x86-64 uses different implemenations.
> We'll try that in a sperate patch; I think the x86-64 one
> is simpler. 
> Well I heard the current x86 (_not_ 64-bit) xenlinux
> failed one of LTP iopl/ioperm testcases (and it passes on
> the native Linux). So I expect some changes are required
> there. Maybe that patch should go first. I'll
> double-check it. 
> Jun
> ---
> Intel Open Source Technology Center
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list