WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xs.h and xs_lib.h

To: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xs.h and xs_lib.h
From: aq <aquynh@xxxxxxxxx>
Date: Mon, 13 Jun 2005 00:14:44 +0900
Cc: Xen Dev <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 12 Jun 2005 15:13:49 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=TGGf9s3I7b4/edjpcXKUFriAjefoFb2k6uBMYqM9JscEgEvxz7Inq6rL20pCN9BjUiFbc+mUtnco7l4z23tnDs1t0ol/6qsJk/QW0xHbPEev8deGQI5BCkN1Vzr/P2zQLU8psRBbbND/mzbFjoqk/WOeLl02JltkHb685h1ZLD8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1118558205.31631.2.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9cde8bff050610013219cd249d@xxxxxxxxxxxxxx> <1118558205.31631.2.camel@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: aq <aquynh@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 6/12/05, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> On Fri, 2005-06-10 at 03:32 -0500, aq wrote:
> > This patch moves declaration of xs_handle from xs.c to xs.h.
> 
> No; why do this?  It's opaque for a reason.  Originally it was just an
> int, but Keir insisted it be an opaque structure.  Exposing it binds us
> to the current structure again.
> 
> > Besides,
> > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile
> > uninstalled them when cleaning up.
> 
> xs_lib.h should not be installed in /usr/include!

i see that, but where should we put this header?

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel