This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] x64-vmxassist-fix.patch

To: Arun Sharma <arun.sharma@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] x64-vmxassist-fix.patch
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sat, 11 Jun 2005 06:39:57 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>
Delivery-date: Sat, 11 Jun 2005 05:42:51 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050610220932.GA28448@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20050610220932.GA28448@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 10 Jun 2005, at 23:09, Arun Sharma wrote:

Fix 64 bit build.

Signed-off-by: Nitin Kamble <nitin.a.kamble@xxxxxxxxx>
Signed-off-by: Arun Sharma <arun.sharma@xxxxxxxxx>

Surely the correct fix is to put a .code32 at the top of the file? The vmxassist stuff should run in 32-bit protected mode: long mode doesn't necessarily support VM86 mode (not on amd chips I believe).

I think the checked-in fix is benign but not the right run-time fix. :-)

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>