WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Guest boot loader support [2/2]

To: Mike Wray <mike.wray@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Guest boot loader support [2/2]
From: Jeremy Katz <katzj@xxxxxxxxxx>
Date: Thu, 14 Apr 2005 12:07:32 -0400
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 14 Apr 2005 16:09:46 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <425E61FF.8080809@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1113448377.5078.51.camel@xxxxxxxxxxxxxx> <425E61FF.8080809@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2005-04-14 at 13:28 +0100, Mike Wray wrote:
> It looks like the code above is missing some brackets in the output:
> shouldn't it be writing "(linux ..." instead of "linux ...",
> and adding a closing ")"?

Adding them causes problems with nesting inside the image.  This is
actually tied into the bit where I go to a string and back in the other
patch.  Given the way things are being passed around, we do actually hae
to do the slightly round-about way instead of the most obvious.

> It might be easier if you used lists for this:
> 
> val = ['linux', ['kernel', fn]]
> val.append(['ramdisk', fn])
> val.append(['args', img.args])
> os.write(fd, sxp.to_string(val))
> 
> This will take care of the brackets, and any string quoting needed.

But adds a dependency on the sxp module.  As it stands now, pygrub is
pretty independent of any xen code.  The biggest problem with adding
such a dep is the path handling for where the sxp module lives.  I guess
I could be convinced if you really think it's better

Jeremy


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>