 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: softirq change was Re: domu_debug support removed on mar
| To: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: softirq change was Re: domu_debug support removed on march 25th from traps.c in -unstable |
| From: | Kip Macy <kip.macy@xxxxxxxxx> |
| Date: | Wed, 13 Apr 2005 11:05:43 -0700 |
| Cc: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Wed, 13 Apr 2005 18:05:40 +0000 |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=LFFr95vzT19/OvttYK7U4GsDpC9vg/N9SlJzr4cA4TGRS4cZ8AUxWW1JokoW0EHp375bZBDsm3sekD2OAkTnTIwy50VIjzTy0Elt1e1WYqhHgUd/JAOufjtB3BAalRAgMfchnGPLAxHoQTMHW9AFfHH8LEf7wa+prCeTWgzUuTM= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <98f0605c58c187fcf208ffabd00cce56@xxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <b1fa29170504122239799bdc51@xxxxxxxxxxxxxx> <b1fa291705041222476a418434@xxxxxxxxxxxxxx> <93009ddb97d608b4b377dd941bfdbe87@xxxxxxxxxxxx> <b1fa291705041310483a8d1b77@xxxxxxxxxxxxxx> <98f0605c58c187fcf208ffabd00cce56@xxxxxxxxxxxx> |
| Reply-to: | Kip Macy <kip.macy@xxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
> You mean that the TF bit is not cleared by the domu_debug code when it
> should be? The correct place to fix this is in
> include/asm-x86/debugger.h in debugger_trap_entry().
Yes. Continuing after single-stepping no longer works.
> In general (not using domu_debug) it is not Xen's job to clear TF. We
> clear it when we 'bounce' the exception into the guest OS, but the
> saved application stack frame will include EFLAGS with the TF bit still
> set. This matches real hardware.
No it isn't Xen's job to clear it under normal circumstances as that
would break PTRACE_SINGLESTEP in user-space. However, it was what the
PDB code was doing and it seemed easy enough to clear it there to
emulate PTRACE_SINGLESTEP for the kernel.
I honestly don't care where it happens, it is easy enough to clear the
TF from xc_ptrace.c. I just happened to be *extremely* tired last
night and was dealing with other issues, so I was frustrated when that
didn't work. I'll just incorporate my fix to xc_ptrace.c in with the
FreeBSD fixes for -unstable.
-Kip
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] address space reorganization, Gerd Knorr |
|---|---|
| Next by Date: | Re: [Xen-devel] BUG at domain.c:144, Christopher S. Aker |
| Previous by Thread: | [Xen-devel] Re: softirq change was Re: domu_debug support removed on march 25th from traps.c in -unstable, Keir Fraser |
| Next by Thread: | [Xen-devel] Bug tracking system, Paul Larson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
