Re: [Xen-devel] [PATCH][RESUBMIT] tools top level makefile cleanup

[Adam Heath <doogie@xxxxxxxxxxxxx>]

On Fri, 25 Mar 2005, Adam Heath wrote:

> On Fri, 25 Mar 2005, Jerone Young wrote:
>
> > +all: check
> > + @for subdir in $(SUBDIRS); do \
> > + $(MAKE) -C $$subdir $@ || exit -1; \
> > + done
>
> How is this a valid makefile?  Where's the tab?

Please use "@set -e; for ...", and remove the "|| exit -1".

Besides, exit -1 is poor, it s/b a positive number.  It's not really possible
to exit with a negative value.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel