This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxen-3.0 (libxc rewrite)

To: Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxen-3.0 (libxc rewrite)
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Tue, 22 Mar 2005 10:06:44 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 23 Mar 2005 16:30:17 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050322160146.GQ31328@xxxxxxxxxxxx>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Organization: IBM
References: <423F3BB5.3020600@xxxxxxxxxx> <3d8eece2050322030245ed31b@xxxxxxxxxxxxxx> <4240340F.8080600@xxxxxxxxxx> <20050322160146.GQ31328@xxxxxxxxxxxx>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0 (X11/20041206)
Christian Limpach wrote:

I think it does what I expect.  And it seems to work for a lot of
libraries just fine.  By not using the global errno, you're preventing
people from using perror, warn, err and the likes.  Also some of the
interfaces in your library are slightly awkward because you're wasting
the return parameter to return the failure reason.
You're right. Some of the interfaces are a little awkward (especially the memory mapping ones). It seemed like a reasonable trade-off to make though.

Even if we don't use the global errno, I'm still wondering why you're
returning -errno and not errno?
Good question. I guess since we never returned > 0 it would be reasonable to return errno instead of -errno. -errno is the convention used in the Linux kernel. That's what I was modelling.

Anthony Liguori


This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
Xen-devel mailing list