WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] 2.6.11-xen-sparse: missing CONFIG_SMP in pgtable

To: Ryan Harper <ryanh@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] 2.6.11-xen-sparse: missing CONFIG_SMP in pgtable-2level
From: Jon Mason <jdmason@xxxxxxxxxx>
Date: Tue, 22 Mar 2005 19:24:49 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 23 Mar 2005 01:26:02 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050322221538.GI24724@xxxxxxxxxxxxxxxxxxxx>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Organization: IBM
References: <20050322221538.GI24724@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.7.2
I was experiencing a similar boot crash on my p4 HT enabled kernel, and the 
patch below fixed my problem.  Good job Ryan!

Thanks,
Jon

On Tuesday 22 March 2005 04:15 pm, Ryan Harper wrote:
> The latest (20050322) xen-unstable fails to boot dom0 when CONFIG_SMP is
> enabled.  The last working snapshot was from 2005-03-18.  I traced the
> problem to a dropped #ifdef CONFIG_SMP in pgtable-2level.h
>
> I've attached a debug trace of dom0 dying without the patch applied.
>
> Ryan Harper
> Software Engineer; Linux Technology Center
> IBM Corp., Austin, Tx
> (512) 838-9253   T/L: 678-9253
> ryanh@xxxxxxxxxx
>
> diffstat output:
>
>  pgtable-2level.h |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletion(-)
>
> Signed-off-by: Ryan Harper <ryanh@xxxxxxxxxx>
> ---
> ---
> a/linux-2.6.11-xen-sparse/include/asm-xen/asm-i386/pgtable-2level.h 2005-03
>-21 22:39:28.000000000 -0600 +++
> b/linux-2.6.11-xen-sparse/include/asm-xen/asm-i386/pgtable-2level.h 2005-03
>-22 15:55:40.000000000 -0600 @@ -13,8 +13,13 @@
>   * within a page table are directly modified.  Thus, the following
>   * hook is made available.
>   */
> +#ifdef CONFIG_SMP
> +#define set_pte(pteptr, pteval) xen_l1_entry_update(pteptr,
> (pteval).pte_low) +#else
>  #define set_pte(pteptr, pteval) (*(pteptr) = pteval)
> -#define set_pte_atomic(pteptr, pteval) set_pte(pteptr,pteval)
> +#endif
> +
> +#define set_pte_atomic(pteptr, pteval) set_pte(pteptr, pteval)
>  #define set_pmd(pmdptr, pmdval) xen_l2_entry_update((pmdptr), (pmdval))
>  #define set_pte_batched(pteptr, pteval) \
>   queue_l1_entry_update(pteptr, (pteval).pte_low)


-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel