This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] "virtual cluster" debug support

To: "Kip Macy" <kip.macy@xxxxxxxxx>
Subject: RE: [Xen-devel] "virtual cluster" debug support
From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Date: Sat, 19 Mar 2005 23:13:46 -0000
Cc: "Xen Developers" <xen-devel@xxxxxxxxxxxxxxxxxxxxx>, <ian.pratt@xxxxxxxxxxxx>, <ian.pratt@xxxxxxxxxxxx>
Delivery-date: Sat, 19 Mar 2005 23:14:06 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
Thread-index: AcUs1MSsB9bz9u3MQ4StthCiMpj8nAAAl6nQ
Thread-topic: [Xen-devel] "virtual cluster" debug support

> What is wrong with {GET/SET}DOMAININFO? These can be done at run-time.
> If you look, you'll see that I explicitly handle the case of removing
> a domain from an existing group before adding it to another.

GET/SETDOMAININFO is used for get/setting the CPU execution state. The
IN parameteres are used for selecting an execution context, and adding a
groupid parameter to them is certainly very odd.

I don't think the patch should touch xc_linux_build either -- setting
the groupid is a generic thing that the tools can do after creating the

The rest looks fine.
[When the domain is first created, groupid should be set to domid. When
choosing a domid for a new domain, avoid picking domid's that are still
in use as a groupid by another domain.]

> I would also appreciate feedback on the correctness of the locking.

Locking looks OK to me, but I'm only reading the patch at the moment --
I always do a final look through after applying.


SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
Xen-devel mailing list