WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] x86 hvm: Remove the extra IS_PRIV_FOR() c

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86 hvm: Remove the extra IS_PRIV_FOR() checks I added to do_hvm_op().
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 09 Apr 2009 23:00:21 -0700
Delivery-date: Thu, 09 Apr 2009 23:01:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1239198192 -3600
# Node ID f9c8c6b0897274ffb682b259b794dde07cb2d8a5
# Parent  eddb0f09fdaff66ce3822699385dc8a01100bad2
x86 hvm: Remove the extra IS_PRIV_FOR() checks I added to do_hvm_op().
Actually this is already done by rcu_lock_target_domain_by_id(). Oops.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/arch/x86/hvm/hvm.c |   16 ----------------
 1 files changed, 16 deletions(-)

diff -r eddb0f09fdaf -r f9c8c6b08972 xen/arch/x86/hvm/hvm.c
--- a/xen/arch/x86/hvm/hvm.c    Wed Apr 08 14:06:37 2009 +0100
+++ b/xen/arch/x86/hvm/hvm.c    Wed Apr 08 14:43:12 2009 +0100
@@ -2439,10 +2439,6 @@ long do_hvm_op(unsigned long op, XEN_GUE
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( (curr_d != d) && !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail;
@@ -2621,10 +2617,6 @@ long do_hvm_op(unsigned long op, XEN_GUE
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail2;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail2;
@@ -2662,10 +2654,6 @@ long do_hvm_op(unsigned long op, XEN_GUE
         rc = rcu_lock_target_domain_by_id(a.domid, &d);
         if ( rc != 0 )
             return rc;
-
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail3;
 
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
@@ -2722,10 +2710,6 @@ long do_hvm_op(unsigned long op, XEN_GUE
         rc = rcu_lock_target_domain_by_id(a.domid, &d);
         if ( rc != 0 )
             return rc;
-
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail4;
 
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86 hvm: Remove the extra IS_PRIV_FOR() checks I added to do_hvm_op()., Xen patchbot-unstable <=