[Xen-changelog] Explain disadvantages of building pciback as a module in Kconfig help.

[Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID 80bc37d5a32fbcd0a9ae35bdc43c0952ff422798
# Parent  d4a2af362e5eae4d201e2b02366948cf87a57e2a
Explain disadvantages of building pciback as a module in Kconfig help.
Fix a module-loading bug in pciback.

From: Jan Beulich
Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>

diff -r d4a2af362e5e -r 80bc37d5a32f linux-2.6-xen-sparse/drivers/xen/Kconfig
--- a/linux-2.6-xen-sparse/drivers/xen/Kconfig  Thu Mar  9 14:16:35 2006
+++ b/linux-2.6-xen-sparse/drivers/xen/Kconfig  Thu Mar  9 14:56:12 2006
@@ -35,7 +35,9 @@
        default XEN_PRIVILEGED_GUEST
        help
          The PCI device backend driver allows the kernel to export arbitrary
-         PCI devices to other guests.
+         PCI devices to other guests. If you select this to be a module, you
+         will need to make sure no other driver has bound to the device(s)
+         you want to make visible to other guests.
 
 choice
        prompt "PCI Backend Mode"
diff -r d4a2af362e5e -r 80bc37d5a32f 
linux-2.6-xen-sparse/drivers/xen/pciback/pci_stub.c
--- a/linux-2.6-xen-sparse/drivers/xen/pciback/pci_stub.c       Thu Mar  9 
14:16:35 2006
+++ b/linux-2.6-xen-sparse/drivers/xen/pciback/pci_stub.c       Thu Mar  9 
14:56:12 2006
@@ -378,7 +378,7 @@
 
 static int __init pciback_init(void)
 {
-#ifndef MODULE
+#ifdef MODULE
        int err;
 
        err = pcistub_init();

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog