# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID 658528fe2b9ad14a06441bcd0f1f1284d57efac6
# Parent e0d8c23acaa7c1d3ae1cf5c591d860037e11fbb8
It's not necessary to define a function for dumping virtual IOAPIC
table entry, that makes the code hard to comply with condition
compiling of HVM_DBG_LOG.
Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>
diff -r e0d8c23acaa7 -r 658528fe2b9a xen/arch/x86/hvm/vioapic.c
--- a/xen/arch/x86/hvm/vioapic.c Fri Mar 3 09:57:37 2006
+++ b/xen/arch/x86/hvm/vioapic.c Fri Mar 3 09:58:42 2006
@@ -52,20 +52,6 @@
s->flags &= ~IOAPIC_ENABLE_FLAG;
}
-static void ioapic_dump_redir(hvm_vioapic_t *s, uint8_t entry)
-{
- RedirStatus redir = s->redirtbl[entry];
-
- printk("ioapic_dump_redir entry %x vector %x "
- "deliver_mod %x destmode %x delivestatus %x "
- "polarity %x remote_irr %x trigmod %x mask %x dest_id %x\n",
- entry, redir.RedirForm.vector, redir.RedirForm.deliver_mode,
- redir.RedirForm.destmode, redir.RedirForm.delivestatus,
- redir.RedirForm.polarity, redir.RedirForm.remoteirr,
- redir.RedirForm.trigmod, redir.RedirForm.mask,
- redir.RedirForm.dest_id);
-}
-
#ifdef HVM_DOMAIN_SAVE_RESTORE
void ioapic_save(QEMUFile* f, void* opaque)
{
@@ -534,7 +520,19 @@
if (!IOAPICEnabled(s) || s->redirtbl[irq].RedirForm.mask)
return;
- ioapic_dump_redir(s, irq);
+ HVM_DBG_LOG(DBG_LEVEL_IOAPIC, "hvm_vioapic_set_irq entry %x "
+ "vector %x deliver_mod %x destmode %x delivestatus %x "
+ "polarity %x remote_irr %x trigmod %x mask %x dest_id %x\n",
+ irq,
+ s->redirtbl[irq].RedirForm.vector,
+ s->redirtbl[irq].RedirForm.deliver_mode,
+ s->redirtbl[irq].RedirForm.destmode,
+ s->redirtbl[irq].RedirForm.delivestatus,
+ s->redirtbl[irq].RedirForm.polarity,
+ s->redirtbl[irq].RedirForm.remoteirr,
+ s->redirtbl[irq].RedirForm.trigmod,
+ s->redirtbl[irq].RedirForm.mask,
+ s->redirtbl[irq].RedirForm.dest_id);
if (irq >= 0 && irq < IOAPIC_NUM_PINS) {
uint32_t bit = 1 << irq;
_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog
|
Home