WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-api

[Xen-API] [PATCH 3 of 6] REBASE-4.1: vmops: apply CPUID to all domains

To: xen-api@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-API] [PATCH 3 of 6] REBASE-4.1: vmops: apply CPUID to all domains
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Tue, 11 Jan 2011 10:56:12 +0000
Cc: gianni.tedesco@xxxxxxxxxx, zheng.li@xxxxxxxxxxxxx
Delivery-date: Tue, 11 Jan 2011 03:49:07 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1294743369@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1294743369@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.5.2
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1294740909 0
# Node ID 7d294cb6a37ebaf8c459d1bb802a2b2d146c1bc1
# Parent  6514f7298111bf3113f93b04543f7d1e41264fb9
REBASE-4.1: vmops: apply CPUID to all domains.

Not just when xenclient is enabled.

I think the indentation was confusing here and the PCI passthrough bit wasn't
actually guarded by Xapi_globs.xenclient_enabled.

Required on newer hypervisor otherwise guest sees all cpuid leafs == 0.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 6514f7298111 -r 7d294cb6a37e ocaml/xapi/vmops.ml
--- a/ocaml/xapi/vmops.ml       Tue Jan 11 10:15:09 2011 +0000
+++ b/ocaml/xapi/vmops.ml       Tue Jan 11 10:15:09 2011 +0000
@@ -1052,11 +1052,10 @@ let start_paused ?(progress_cb = fun _ -
 
                      let hvm = Helpers.is_hvm snapshot in                      
 
-                     if Xapi_globs.xenclient_enabled then 
-                       Domain.cpuid_apply ~xc ~hvm domid;
+                     Domain.cpuid_apply ~xc ~hvm domid;
 
-                         (* XXX: PCI passthrough needs a lot of work *)
-                         let pcidevs = (match pcidevs with Some x -> x | None 
-> pcidevs_of_vm ~__context ~vm) in
+                     (* XXX: PCI passthrough needs a lot of work *)
+                     let pcidevs = (match pcidevs with Some x -> x | None -> 
pcidevs_of_vm ~__context ~vm) in
 
                      (* Don't attempt to attach empty VBDs to PV guests: they 
can't handle them *)
                      let vbds = 

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api

<Prev in Thread] Current Thread [Next in Thread>